Fix matchstick prediction issues #31418
Open
+197
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I think you need to update yml of matches too... |
|
Your right but I have no idea why its failing... Isn't the default variable name lowercase? It was: |
|
Try removing read-only access, I don't know. |
|
Uh... The old one was read-only too... |
|
OK we couldn't figure out why it always fails when the datafield names are removed (Even when the names would still work...). Just leaving them there! |
metalgearsloth
requested changes
Sep 20, 2024
Comment on lines
2
to
8
|
|
||
| // TODO make changes in icons when different threshold reached | ||
| // e.g. different icons for 10% 50% 100% | ||
| [RegisterComponent] | ||
| public sealed partial class MatchboxComponent : Component | ||
| { | ||
| } |
Comment on lines
24
to
30
|
|
||
| /// <summary> | ||
| /// The time that the match will burn out. If null, that means the match is unlit. | ||
| /// </summary> | ||
| [AutoNetworkedField] | ||
| public TimeSpan? TimeMatchWillBurnOut = null; | ||
|
|
There was a problem hiding this comment.
Needs autopausedfield.
metalgearsloth
added
the
Status: Awaiting Changes
github-actions
bot
added
Status: Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Matchstick was always miss predicting getting inserted into a container. There was an outdated method that I fixed as well.
Technical details
The only sussy thing I had to do was always make the event handled if a matchstick is used on a matchbox. If you don't do that and check for it being lit and then making it list if its not, it starts misrepresenting on the second round because the match becomes lit and the event wouldn't be handled.
* This works the first time but the second time it will never trigger so it won't get handled and gets inserted.
Media
2024-08-24.22-39-04.mp4
Requirements